You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed in main (5169a9b) that some extra directories of the setuptools project ended up exposed by the editable wheel. Specifically launcher and newsfragments. This is a quick reproducer:
I imagine that the reason why newsfragments and launcher are not included in the regular wheel is because setup.cfg/setup.py does not have package_data = [...] or include_package_data = True, so the .rst and .exe files are excluded from the wheel, and therefore the newsfragments and launcher directories end up empty during the build, which will automatically remove them from the zip (zip files cannot contain empty directories right?)
The expectation would be that the packages configuration exclude these directories by default (even if they don't contain .py files) to prevent errors (e.g. in the future we could end up adding files to these directories that are captured by setuptools package_data or include_package_data).
The text was updated successfully, but these errors were encountered:
I noticed in
main
(5169a9b) that some extra directories of thesetuptools
project ended up exposed by the editable wheel. Specificallylauncher
andnewsfragments
. This is a quick reproducer:This is likely caused by the way
packages = find_namespace:
is configured insetup.cfg
.We can check that by running:
I imagine that the reason why
newsfragments
andlauncher
are not included in the regular wheel is becausesetup.cfg/setup.py
does not havepackage_data = [...]
orinclude_package_data = True
, so the.rst
and.exe
files are excluded from the wheel, and therefore thenewsfragments
andlauncher
directories end up empty during the build, which will automatically remove them from the zip (zip files cannot contain empty directories right?)The expectation would be that the
packages
configuration exclude these directories by default (even if they don't contain.py
files) to prevent errors (e.g. in the future we could end up adding files to these directories that are captured by setuptoolspackage_data
orinclude_package_data
).The text was updated successfully, but these errors were encountered: