Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should support for sdists in tar.bz2 format be kept? #1196

Closed
1 task done
dnicolodi opened this issue Dec 4, 2024 · 2 comments · Fixed by #1200
Closed
1 task done

Should support for sdists in tar.bz2 format be kept? #1196

dnicolodi opened this issue Dec 4, 2024 · 2 comments · Fixed by #1200

Comments

@dnicolodi
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues (open and closed), and could not find an existing issue

What keywords did you use to search existing issues?

No response

Please describe the problem you are attempting to solve with this request

Currently twine allows for sdists in tar.bz2 format. However, these are rejected by PyPI. Should support for this archive compression format be kept alongside tar.gz? Is it allowed by other package indexes?

How do you think we should solve this?

No response

Anything else you'd like to mention?

No response

@woodruffw
Copy link
Member

I think this is similar to egg/wininst: PyPI and TestPyPI definitely don't support these, and I suspect that no other third-party indices do either given PEP 527.

Given that, I think this could be removed, but I'm curious what others think.


From some quick searching online:

@dnicolodi
Copy link
Contributor Author

I don't know how much the AWS CodeArtifact documentation can be trusted: it contains a twine upload command that does not work because the .tgz filename extension is not supported https://docs.aws.amazon.com/codeartifact/latest/ug/python-configure-twine.html

twine/twine/package.py

Lines 56 to 63 in 2319d1c

DIST_EXTENSIONS = {
".whl": "bdist_wheel",
".exe": "bdist_wininst",
".egg": "bdist_egg",
".tar.bz2": "sdist",
".tar.gz": "sdist",
".zip": "sdist",
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants