-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to turn twine check warnings into errors #562
Comments
Sorry, it's not currently possible to turn these into errors. In addition: these are warnings and not errors for a reason: Can you give a bit more detail about why you want this to cause a failure? |
The warnings seem like they're there to warn :) -- if there's literally nothing bad about them all good, but by having them it sounds like there's something to fix -- when For analogy, e.g. Does that make any more sense? |
That sounds reasonable to me; I'd probably do something like |
I disagree @bhrutledge. Those warnings in particular are informational and don't require fixing. They're useful if and only if you're using markdown for the long description. Unlike sphinx the (I think only) warnings here are not guaranteed to be error worthy in what I'd guess is the majority use-case. |
Cool, that's fine with me too if that's the case -- that means twine will guarantee that warnings emitted by it will never require action? |
I think we can probably make that guarantee. |
Sounds good thanks! |
Can we please reopen this? It makes no sense to not have a strict mode. I recently uploaded a package with empty description on pypi because during conversion from README.rst to README.md I forgot to update the setup.cfg file. Yes, I did had a |
IMHO it's sane to have |
As the maintainer with the narrowest perspective, |
(Re-opening, since I agree that that example seems to already not meet the "guarantee" above, but yeah obviously if there's still disagreement I won't feel bad if this is re-closed) |
|
Hi!
twine check
looks like beyond just failing if the output is invalid, it can output some warnings. E.g.:Not sure if there are other warnings it raises today --
twine check
looks like it exits non-zero if an actual error occurs, but for nitpicky's sake, it seems like it'd be nice to be able to fail for warnings too.(Apologies if there's some other way besides a CLI argument to do this and I missed it)
The text was updated successfully, but these errors were encountered: