virtualenv doesn't work if TCL is not installed

[davidhyman]

If (for any reason) the user did not elect to install TCL / TK during installation, we get the following error:

  File "c:\python35-32\lib\site-packages\virtualenv.py", line 329, in copyfileordir
    shutil.copy2(src, dest)
  File "c:\python35-32\lib\shutil.py", line 251, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "c:\python35-32\lib\shutil.py", line 114, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: 'c:\\python35-32/tcl/tcl8.6'

The relevant code is that added to fix #93
#911

I propose the following patch (at ln1076) along the same lines as the code used elsewhere for the dll files (ln1277):

    for name in ['tcl', 'tk']:
        srcdir = src + '/tcl/' + name + libver
        dstdir = dest + '/tcl/' + name + libver
        if os.path.exists(srcdir):
            copyfileordir(srcdir, dstdir, symlink)
        else:
            logger.notify('omitted %s %s because it was not in the source Python distribution', name, libver)

This is a clear message and is forward-compatible should the user later elect to install tkinter and re-create the virtual environment.

[davidhyman]

Also at a guess this should originally have been written using os.path, rather than string concat?

[jayvdb]

Yes re using os.path , but / usually works on Windows as it is the os.altsep on Windows.

[Ivoz]

Hi there, 6431406 should have solved this issue, and is now in 15.0.3

[c0d3h4x0r]

Hi there, 6431406 should have solved this issue, and is now in 15.0.3

That did not fix it on Mac.

[gaborbernat]

Can you test with 20.0.0b2? I believe that should have fixed this.