-
Notifications
You must be signed in to change notification settings - Fork 961
/
test_legacy.py
3460 lines (2928 loc) · 120 KB
/
test_legacy.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import hashlib
import io
import re
import tarfile
import tempfile
import zipfile
from cgi import FieldStorage
from unittest import mock
import pkg_resources
import pretend
import pytest
import requests
from pyramid.httpexceptions import HTTPBadRequest, HTTPForbidden
from sqlalchemy.exc import IntegrityError
from sqlalchemy.orm import joinedload
from trove_classifiers import classifiers
from webob.multidict import MultiDict
from wtforms.form import Form
from wtforms.validators import ValidationError
from warehouse.admin.flags import AdminFlag, AdminFlagValue
from warehouse.classifiers.models import Classifier
from warehouse.forklift import legacy
from warehouse.metrics import IMetricsService
from warehouse.packaging.interfaces import IFileStorage
from warehouse.packaging.models import (
Dependency,
DependencyKind,
File,
Filename,
JournalEntry,
Project,
Release,
Role,
)
from warehouse.packaging.tasks import update_bigquery_release_files
from ...common.db.accounts import EmailFactory, UserFactory
from ...common.db.classifiers import ClassifierFactory
from ...common.db.packaging import (
FileFactory,
ProjectFactory,
ReleaseFactory,
RoleFactory,
)
def _get_tar_testdata(compression_type=""):
temp_f = io.BytesIO()
with tarfile.open(fileobj=temp_f, mode=f"w:{compression_type}") as tar:
tar.add("/dev/null", arcname="fake_package/PKG-INFO")
return temp_f.getvalue()
_TAR_GZ_PKG_TESTDATA = _get_tar_testdata("gz")
_TAR_GZ_PKG_MD5 = hashlib.md5(_TAR_GZ_PKG_TESTDATA).hexdigest()
_TAR_GZ_PKG_SHA256 = hashlib.sha256(_TAR_GZ_PKG_TESTDATA).hexdigest()
_TAR_GZ_PKG_STORAGE_HASH = hashlib.blake2b(
_TAR_GZ_PKG_TESTDATA, digest_size=256 // 8
).hexdigest()
_TAR_BZ2_PKG_TESTDATA = _get_tar_testdata("bz2")
_TAR_BZ2_PKG_MD5 = hashlib.md5(_TAR_BZ2_PKG_TESTDATA).hexdigest()
_TAR_BZ2_PKG_SHA256 = hashlib.sha256(_TAR_BZ2_PKG_TESTDATA).hexdigest()
_TAR_BZ2_PKG_STORAGE_HASH = hashlib.blake2b(
_TAR_BZ2_PKG_TESTDATA, digest_size=256 // 8
).hexdigest()
class TestExcWithMessage:
def test_exc_with_message(self):
exc = legacy._exc_with_message(HTTPBadRequest, "My Test Message.")
assert isinstance(exc, HTTPBadRequest)
assert exc.status_code == 400
assert exc.status == "400 My Test Message."
def test_exc_with_exotic_message(self):
exc = legacy._exc_with_message(
HTTPBadRequest, "look at these wild chars: аä‗"
)
assert isinstance(exc, HTTPBadRequest)
assert exc.status_code == 400
assert exc.status == "400 look at these wild chars: ?äâ??"
class TestValidation:
@pytest.mark.parametrize("version", ["1.0", "30a1", "1!1", "1.0-1"])
def test_validates_valid_pep440_version(self, version):
form, field = pretend.stub(), pretend.stub(data=version)
legacy._validate_pep440_version(form, field)
@pytest.mark.parametrize("version", ["dog", "1.0.dev.a1", "1.0+local"])
def test_validates_invalid_pep440_version(self, version):
form, field = pretend.stub(), pretend.stub(data=version)
with pytest.raises(ValidationError):
legacy._validate_pep440_version(form, field)
@pytest.mark.parametrize(
("requirement", "expected"),
[("foo", ("foo", None)), ("foo (>1.0)", ("foo", ">1.0"))],
)
def test_parses_legacy_requirement_valid(self, requirement, expected):
parsed = legacy._parse_legacy_requirement(requirement)
assert parsed == expected
@pytest.mark.parametrize("requirement", ["foo bar"])
def test_parses_legacy_requirement_invalid(self, requirement):
with pytest.raises(ValueError):
legacy._parse_legacy_requirement(requirement)
@pytest.mark.parametrize("specifier", [">=1.0", "<=1.0-1"])
def test_validates_valid_pep440_specifier(self, specifier):
legacy._validate_pep440_specifier(specifier)
@pytest.mark.parametrize("specifier", ["wat?"])
def test_validates_invalid_pep440_specifier(self, specifier):
with pytest.raises(ValidationError):
legacy._validate_pep440_specifier(specifier)
@pytest.mark.parametrize(
"requirement", ["foo (>=1.0)", "foo", "_foo", "foo2", "foo.bar"]
)
def test_validates_legacy_non_dist_req_valid(self, requirement):
legacy._validate_legacy_non_dist_req(requirement)
@pytest.mark.parametrize(
"requirement",
[
"foo-bar (>=1.0)",
"foo-bar",
"2foo (>=1.0)",
"2foo",
"☃ (>=1.0)",
"☃",
"name @ https://github.com/pypa",
"foo.2bar",
],
)
def test_validates_legacy_non_dist_req_invalid(self, requirement):
with pytest.raises(ValidationError):
legacy._validate_legacy_non_dist_req(requirement)
def test_validate_legacy_non_dist_req_list(self, monkeypatch):
validator = pretend.call_recorder(lambda datum: None)
monkeypatch.setattr(legacy, "_validate_legacy_non_dist_req", validator)
data = [pretend.stub(), pretend.stub(), pretend.stub()]
form, field = pretend.stub(), pretend.stub(data=data)
legacy._validate_legacy_non_dist_req_list(form, field)
assert validator.calls == [pretend.call(datum) for datum in data]
@pytest.mark.parametrize(
"requirement",
["foo (>=1.0)", "foo", "foo2", "foo-bar", "foo_bar", "foo == 2.*"],
)
def test_validate_legacy_dist_req_valid(self, requirement):
legacy._validate_legacy_dist_req(requirement)
@pytest.mark.parametrize(
"requirement",
[
"☃ (>=1.0)",
"☃",
"foo-",
"foo- (>=1.0)",
"_foo",
"_foo (>=1.0)",
"name @ https://github.com/pypa",
],
)
def test_validate_legacy_dist_req_invalid(self, requirement):
with pytest.raises(ValidationError):
legacy._validate_legacy_dist_req(requirement)
def test_validate_legacy_dist_req_list(self, monkeypatch):
validator = pretend.call_recorder(lambda datum: None)
monkeypatch.setattr(legacy, "_validate_legacy_dist_req", validator)
data = [pretend.stub(), pretend.stub(), pretend.stub()]
form, field = pretend.stub(), pretend.stub(data=data)
legacy._validate_legacy_dist_req_list(form, field)
assert validator.calls == [pretend.call(datum) for datum in data]
@pytest.mark.parametrize(
("requirement", "specifier"), [("C", None), ("openssl (>=1.0.0)", ">=1.0.0")]
)
def test_validate_requires_external(self, monkeypatch, requirement, specifier):
spec_validator = pretend.call_recorder(lambda spec: None)
monkeypatch.setattr(legacy, "_validate_pep440_specifier", spec_validator)
legacy._validate_requires_external(requirement)
if specifier is not None:
assert spec_validator.calls == [pretend.call(specifier)]
else:
assert spec_validator.calls == []
def test_validate_requires_external_list(self, monkeypatch):
validator = pretend.call_recorder(lambda datum: None)
monkeypatch.setattr(legacy, "_validate_requires_external", validator)
data = [pretend.stub(), pretend.stub(), pretend.stub()]
form, field = pretend.stub(), pretend.stub(data=data)
legacy._validate_requires_external_list(form, field)
assert validator.calls == [pretend.call(datum) for datum in data]
@pytest.mark.parametrize(
"project_url",
["Home, https://pypi.python.org/", ("A" * 32) + ", https://example.com/"],
)
def test_validate_project_url_valid(self, project_url):
legacy._validate_project_url(project_url)
@pytest.mark.parametrize(
"project_url",
[
"Home,https://pypi.python.org/",
"https://pypi.python.org/",
", https://pypi.python.org/",
"Home, ",
("A" * 33) + ", https://example.com/",
"Home, I am a banana",
"Home, ssh://foobar",
"",
],
)
def test_validate_project_url_invalid(self, project_url):
with pytest.raises(ValidationError):
legacy._validate_project_url(project_url)
@pytest.mark.parametrize(
"project_urls",
[["Home, https://pypi.python.org/", ("A" * 32) + ", https://example.com/"]],
)
def test_all_valid_project_url_list(self, project_urls):
form, field = pretend.stub(), pretend.stub(data=project_urls)
legacy._validate_project_url_list(form, field)
@pytest.mark.parametrize(
"project_urls",
[
["Home, https://pypi.python.org/", ""], # Valid # Invalid
[
("A" * 32) + ", https://example.com/", # Valid
("A" * 33) + ", https://example.com/", # Invalid
],
],
)
def test_invalid_member_project_url_list(self, project_urls):
form, field = pretend.stub(), pretend.stub(data=project_urls)
with pytest.raises(ValidationError):
legacy._validate_project_url_list(form, field)
def test_validate_project_url_list(self, monkeypatch):
validator = pretend.call_recorder(lambda datum: None)
monkeypatch.setattr(legacy, "_validate_project_url", validator)
data = [pretend.stub(), pretend.stub(), pretend.stub()]
form, field = pretend.stub(), pretend.stub(data=data)
legacy._validate_project_url_list(form, field)
assert validator.calls == [pretend.call(datum) for datum in data]
@pytest.mark.parametrize(
"data",
[
(""),
("foo@bar.com"),
("foo@bar.com,"),
("foo@bar.com, biz@baz.com"),
('"C. Schultz" <cschultz@example.com>'),
('"C. Schultz" <cschultz@example.com>, snoopy@peanuts.com'),
],
)
def test_validate_rfc822_email_field(self, data):
form, field = pretend.stub(), pretend.stub(data=data)
legacy._validate_rfc822_email_field(form, field)
@pytest.mark.parametrize(
"data",
[
("foo"),
("foo@"),
("@bar.com"),
("foo@bar"),
("foo AT bar DOT com"),
("foo@bar.com, foo"),
],
)
def test_validate_rfc822_email_field_raises(self, data):
form, field = pretend.stub(), pretend.stub(data=data)
with pytest.raises(ValidationError):
legacy._validate_rfc822_email_field(form, field)
@pytest.mark.parametrize(
"data",
[
"text/plain; charset=UTF-8",
"text/x-rst; charset=UTF-8",
"text/markdown; charset=UTF-8; variant=CommonMark",
"text/markdown; charset=UTF-8; variant=GFM",
"text/markdown",
],
)
def test_validate_description_content_type_valid(self, data):
form, field = pretend.stub(), pretend.stub(data=data)
legacy._validate_description_content_type(form, field)
@pytest.mark.parametrize(
"data",
[
"invalid_type/plain",
"text/invalid_subtype",
"text/plain; charset=invalid_charset",
"text/markdown; charset=UTF-8; variant=invalid_variant",
],
)
def test_validate_description_content_type_invalid(self, data):
form, field = pretend.stub(), pretend.stub(data=data)
with pytest.raises(ValidationError):
legacy._validate_description_content_type(form, field)
def test_validate_no_deprecated_classifiers_valid(self, db_request):
valid_classifier = ClassifierFactory(classifier="AA :: BB")
form = pretend.stub()
field = pretend.stub(data=[valid_classifier.classifier])
legacy._validate_no_deprecated_classifiers(form, field)
@pytest.mark.parametrize(
"deprecated_classifiers", [({"AA :: BB": []}), ({"AA :: BB": ["CC :: DD"]})]
)
def test_validate_no_deprecated_classifiers_invalid(
self, db_request, deprecated_classifiers, monkeypatch
):
monkeypatch.setattr(legacy, "deprecated_classifiers", deprecated_classifiers)
form = pretend.stub()
field = pretend.stub(data=["AA :: BB"])
with pytest.raises(ValidationError):
legacy._validate_no_deprecated_classifiers(form, field)
def test_validate_classifiers_valid(self, db_request, monkeypatch):
monkeypatch.setattr(legacy, "classifiers", {"AA :: BB"})
form = pretend.stub()
field = pretend.stub(data=["AA :: BB"])
legacy._validate_classifiers(form, field)
@pytest.mark.parametrize("data", [(["AA :: BB"]), (["AA :: BB", "CC :: DD"])])
def test_validate_classifiers_invalid(self, db_request, data):
form = pretend.stub()
field = pretend.stub(data=data)
with pytest.raises(ValidationError):
legacy._validate_classifiers(form, field)
def test_construct_dependencies():
types = {"requires": DependencyKind.requires, "provides": DependencyKind.provides}
form = pretend.stub(
requires=pretend.stub(data=["foo (>1)"]),
provides=pretend.stub(data=["bar (>2)"]),
)
for dep in legacy._construct_dependencies(form, types):
assert isinstance(dep, Dependency)
if dep.kind == DependencyKind.requires:
assert dep.specifier == "foo (>1)"
elif dep.kind == DependencyKind.provides:
assert dep.specifier == "bar (>2)"
else:
pytest.fail("Unknown type of specifier")
class TestListField:
@pytest.mark.parametrize(
("data", "expected"),
[
(["foo", "bar"], ["foo", "bar"]),
([" foo"], ["foo"]),
(["f oo "], ["f oo"]),
("", []),
(" ", []),
],
)
def test_processes_form_data(self, data, expected):
field = legacy.ListField()
field = field.bind(pretend.stub(meta=pretend.stub()), "formname")
field.process_formdata(data)
assert field.data == expected
@pytest.mark.parametrize(("value", "expected"), [("", []), ("wutang", ["wutang"])])
def test_coerce_string_into_list(self, value, expected):
class MyForm(Form):
test = legacy.ListField()
form = MyForm(MultiDict({"test": value}))
assert form.test.data == expected
class TestMetadataForm:
@pytest.mark.parametrize(
"data",
[
{"filetype": "sdist", "md5_digest": "bad"},
{"filetpye": "bdist_wheel", "pyversion": "3.4", "md5_digest": "bad"},
{"filetype": "sdist", "sha256_digest": "bad"},
{"filetpye": "bdist_wheel", "pyversion": "3.4", "sha256_digest": "bad"},
{"filetype": "sdist", "md5_digest": "bad", "sha256_digest": "bad"},
{
"filetpye": "bdist_wheel",
"pyversion": "3.4",
"md5_digest": "bad",
"sha256_digest": "bad",
},
],
)
def test_full_validate_valid(self, data):
form = legacy.MetadataForm(MultiDict(data))
form.full_validate()
@pytest.mark.parametrize(
"data", [{"filetype": "sdist", "pyversion": "3.4"}, {"filetype": "bdist_wheel"}]
)
def test_full_validate_invalid(self, data):
form = legacy.MetadataForm(MultiDict(data))
with pytest.raises(ValidationError):
form.full_validate()
def test_requires_python(self):
form = legacy.MetadataForm(MultiDict({"requires_python": ">= 3.5"}))
form.requires_python.validate(form)
class TestFileValidation:
def test_defaults_to_true(self):
assert legacy._is_valid_dist_file("", "")
@pytest.mark.parametrize(
("filename", "filetype"),
[("test.exe", "bdist_msi"), ("test.msi", "bdist_wininst")],
)
def test_bails_with_invalid_package_type(self, filename, filetype):
assert not legacy._is_valid_dist_file(filename, filetype)
@pytest.mark.parametrize(
("filename", "filetype"),
[
("test.exe", "bdist_wininst"),
("test.zip", "sdist"),
("test.egg", "bdist_egg"),
("test.whl", "bdist_wheel"),
],
)
def test_bails_with_invalid_zipfile(self, tmpdir, filename, filetype):
f = str(tmpdir.join(filename))
with open(f, "wb") as fp:
fp.write(b"this isn't a valid zip file")
assert not legacy._is_valid_dist_file(f, filetype)
@pytest.mark.parametrize(
"filename", ["test.tar", "test.tar.gz", "test.tgz", "test.tar.bz2", "test.tbz2"]
)
def test_bails_with_invalid_tarfile(self, tmpdir, filename):
fake_tar = str(tmpdir.join(filename))
with open(fake_tar, "wb") as fp:
fp.write(b"Definitely not a valid tar file.")
assert not legacy._is_valid_dist_file(fake_tar, "sdist")
@pytest.mark.parametrize("compression", ("", "gz", "bz2"))
def test_tarfile_validation_invalid(self, tmpdir, compression):
file_extension = f".{compression}" if compression else ""
tar_fn = str(tmpdir.join(f"test.tar{file_extension}"))
data_file = str(tmpdir.join("dummy_data"))
with open(data_file, "wb") as fp:
fp.write(b"Dummy data file.")
with tarfile.open(tar_fn, f"w:{compression}") as tar:
tar.add(data_file, arcname="package/module.py")
assert not legacy._is_valid_dist_file(
tar_fn, "sdist"
), "no PKG-INFO; should fail"
@pytest.mark.parametrize("compression", ("", "gz", "bz2"))
def test_tarfile_validation_valid(self, tmpdir, compression):
file_extension = f".{compression}" if compression else ""
tar_fn = str(tmpdir.join(f"test.tar{file_extension}"))
data_file = str(tmpdir.join("dummy_data"))
with open(data_file, "wb") as fp:
fp.write(b"Dummy data file.")
with tarfile.open(tar_fn, f"w:{compression}") as tar:
tar.add(data_file, arcname="package/module.py")
tar.add(data_file, arcname="package/PKG-INFO")
tar.add(data_file, arcname="package/data_file.txt")
assert legacy._is_valid_dist_file(tar_fn, "sdist")
def test_wininst_unsafe_filename(self, tmpdir):
f = str(tmpdir.join("test.exe"))
with zipfile.ZipFile(f, "w") as zfp:
zfp.writestr("something/bar.py", b"the test file")
assert not legacy._is_valid_dist_file(f, "bdist_wininst")
def test_wininst_safe_filename(self, tmpdir):
f = str(tmpdir.join("test.exe"))
with zipfile.ZipFile(f, "w") as zfp:
zfp.writestr("purelib/bar.py", b"the test file")
assert legacy._is_valid_dist_file(f, "bdist_wininst")
def test_msi_invalid_header(self, tmpdir):
f = str(tmpdir.join("test.msi"))
with open(f, "wb") as fp:
fp.write(b"this isn't the correct header for an msi")
assert not legacy._is_valid_dist_file(f, "bdist_msi")
def test_msi_valid_header(self, tmpdir):
f = str(tmpdir.join("test.msi"))
with open(f, "wb") as fp:
fp.write(b"\xD0\xCF\x11\xE0\xA1\xB1\x1A\xE1")
assert legacy._is_valid_dist_file(f, "bdist_msi")
def test_zip_no_pkg_info(self, tmpdir):
f = str(tmpdir.join("test.zip"))
with zipfile.ZipFile(f, "w") as zfp:
zfp.writestr("something.txt", b"Just a placeholder file")
assert not legacy._is_valid_dist_file(f, "sdist")
def test_zip_has_pkg_info(self, tmpdir):
f = str(tmpdir.join("test.zip"))
with zipfile.ZipFile(f, "w") as zfp:
zfp.writestr("something.txt", b"Just a placeholder file")
zfp.writestr("PKG-INFO", b"this is the package info")
assert legacy._is_valid_dist_file(f, "sdist")
def test_zipfile_supported_compression(self, tmpdir):
f = str(tmpdir.join("test.zip"))
with zipfile.ZipFile(f, "w") as zfp:
zfp.writestr("PKG-INFO", b"this is the package info")
zfp.writestr("1.txt", b"1", zipfile.ZIP_STORED)
zfp.writestr("2.txt", b"2", zipfile.ZIP_DEFLATED)
assert legacy._is_valid_dist_file(f, "")
@pytest.mark.parametrize("method", [zipfile.ZIP_BZIP2, zipfile.ZIP_LZMA])
def test_zipfile_unsupported_compression(self, tmpdir, method):
f = str(tmpdir.join("test.zip"))
with zipfile.ZipFile(f, "w") as zfp:
zfp.writestr("1.txt", b"1", zipfile.ZIP_STORED)
zfp.writestr("2.txt", b"2", zipfile.ZIP_DEFLATED)
zfp.writestr("3.txt", b"3", method)
assert not legacy._is_valid_dist_file(f, "")
def test_egg_no_pkg_info(self, tmpdir):
f = str(tmpdir.join("test.egg"))
with zipfile.ZipFile(f, "w") as zfp:
zfp.writestr("something.txt", b"Just a placeholder file")
assert not legacy._is_valid_dist_file(f, "bdist_egg")
def test_egg_has_pkg_info(self, tmpdir):
f = str(tmpdir.join("test.egg"))
with zipfile.ZipFile(f, "w") as zfp:
zfp.writestr("something.txt", b"Just a placeholder file")
zfp.writestr("PKG-INFO", b"this is the package info")
assert legacy._is_valid_dist_file(f, "bdist_egg")
def test_wheel_no_wheel_file(self, tmpdir):
f = str(tmpdir.join("test.whl"))
with zipfile.ZipFile(f, "w") as zfp:
zfp.writestr("something.txt", b"Just a placeholder file")
assert not legacy._is_valid_dist_file(f, "bdist_wheel")
def test_wheel_has_wheel_file(self, tmpdir):
f = str(tmpdir.join("test.whl"))
with zipfile.ZipFile(f, "w") as zfp:
zfp.writestr("something.txt", b"Just a placeholder file")
zfp.writestr("WHEEL", b"this is the package info")
assert legacy._is_valid_dist_file(f, "bdist_wheel")
class TestIsDuplicateFile:
def test_is_duplicate_true(self, pyramid_config, db_request):
pyramid_config.testing_securitypolicy(userid=1)
user = UserFactory.create()
EmailFactory.create(user=user)
project = ProjectFactory.create()
release = ReleaseFactory.create(project=project, version="1.0")
RoleFactory.create(user=user, project=project)
filename = "{}-{}.tar.gz".format(project.name, release.version)
file_content = io.BytesIO(_TAR_GZ_PKG_TESTDATA)
file_value = file_content.getvalue()
hashes = {
"sha256": hashlib.sha256(file_value).hexdigest(),
"md5": hashlib.md5(file_value).hexdigest(),
"blake2_256": hashlib.blake2b(file_value, digest_size=256 // 8).hexdigest(),
}
db_request.db.add(
File(
release=release,
filename=filename,
md5_digest=hashes["md5"],
sha256_digest=hashes["sha256"],
blake2_256_digest=hashes["blake2_256"],
path="source/{name[0]}/{name}/{filename}".format(
name=project.name, filename=filename
),
)
)
assert legacy._is_duplicate_file(db_request.db, filename, hashes)
def test_is_duplicate_none(self, pyramid_config, db_request):
pyramid_config.testing_securitypolicy(userid=1)
user = UserFactory.create()
EmailFactory.create(user=user)
project = ProjectFactory.create()
release = ReleaseFactory.create(project=project, version="1.0")
RoleFactory.create(user=user, project=project)
filename = "{}-{}.tar.gz".format(project.name, release.version)
requested_file_name = "{}-{}-1.tar.gz".format(project.name, release.version)
file_content = io.BytesIO(_TAR_GZ_PKG_TESTDATA)
file_value = file_content.getvalue()
hashes = {
"sha256": hashlib.sha256(file_value).hexdigest(),
"md5": hashlib.md5(file_value).hexdigest(),
"blake2_256": hashlib.blake2b(file_value, digest_size=256 // 8).hexdigest(),
}
db_request.db.add(
File(
release=release,
filename=filename,
md5_digest=hashes["md5"],
sha256_digest=hashes["sha256"],
blake2_256_digest=hashes["blake2_256"],
path="source/{name[0]}/{name}/{filename}".format(
name=project.name, filename=filename
),
)
)
hashes["blake2_256"] = "another blake2 digest"
assert (
legacy._is_duplicate_file(db_request.db, requested_file_name, hashes)
is None
)
def test_is_duplicate_false_same_blake2(self, pyramid_config, db_request):
pyramid_config.testing_securitypolicy(userid=1)
user = UserFactory.create()
EmailFactory.create(user=user)
project = ProjectFactory.create()
release = ReleaseFactory.create(project=project, version="1.0")
RoleFactory.create(user=user, project=project)
filename = "{}-{}.tar.gz".format(project.name, release.version)
requested_file_name = "{}-{}-1.tar.gz".format(project.name, release.version)
file_content = io.BytesIO(_TAR_GZ_PKG_TESTDATA)
file_value = file_content.getvalue()
hashes = {
"sha256": hashlib.sha256(file_value).hexdigest(),
"md5": hashlib.md5(file_value).hexdigest(),
"blake2_256": hashlib.blake2b(file_value, digest_size=256 // 8).hexdigest(),
}
db_request.db.add(
File(
release=release,
filename=filename,
md5_digest=hashes["md5"],
sha256_digest=hashes["sha256"],
blake2_256_digest=hashes["blake2_256"],
path="source/{name[0]}/{name}/{filename}".format(
name=project.name, filename=filename
),
)
)
assert (
legacy._is_duplicate_file(db_request.db, requested_file_name, hashes)
is False
)
def test_is_duplicate_false(self, pyramid_config, db_request):
pyramid_config.testing_securitypolicy(userid=1)
user = UserFactory.create()
EmailFactory.create(user=user)
project = ProjectFactory.create()
release = ReleaseFactory.create(project=project, version="1.0")
RoleFactory.create(user=user, project=project)
filename = "{}-{}.tar.gz".format(project.name, release.version)
file_content = io.BytesIO(_TAR_GZ_PKG_TESTDATA)
file_value = file_content.getvalue()
hashes = {
"sha256": hashlib.sha256(file_value).hexdigest(),
"md5": hashlib.md5(file_value).hexdigest(),
"blake2_256": hashlib.blake2b(file_value, digest_size=256 // 8).hexdigest(),
}
wrong_hashes = {"sha256": "nah", "md5": "nope", "blake2_256": "nuh uh"}
db_request.db.add(
File(
release=release,
filename=filename,
md5_digest=hashes["md5"],
sha256_digest=hashes["sha256"],
blake2_256_digest=hashes["blake2_256"],
path="source/{name[0]}/{name}/{filename}".format(
name=project.name, filename=filename
),
)
)
assert legacy._is_duplicate_file(db_request.db, filename, wrong_hashes) is False
class TestFileUpload:
def test_fails_disallow_new_upload(self, pyramid_config, pyramid_request):
pyramid_config.testing_securitypolicy(userid=1)
pyramid_request.flags = pretend.stub(
enabled=lambda value: value == AdminFlagValue.DISALLOW_NEW_UPLOAD
)
pyramid_request.help_url = pretend.call_recorder(lambda **kw: "/the/help/url/")
pyramid_request.user = pretend.stub(primary_email=pretend.stub(verified=True))
with pytest.raises(HTTPForbidden) as excinfo:
legacy.file_upload(pyramid_request)
resp = excinfo.value
assert resp.status_code == 403
assert resp.status == (
"403 New uploads are temporarily disabled. "
"See /the/help/url/ for more information."
)
@pytest.mark.parametrize("version", ["2", "3", "-1", "0", "dog", "cat"])
def test_fails_invalid_version(self, pyramid_config, pyramid_request, version):
pyramid_config.testing_securitypolicy(userid=1)
pyramid_request.POST["protocol_version"] = version
pyramid_request.flags = pretend.stub(enabled=lambda *a: False)
pyramid_request.user = pretend.stub(primary_email=pretend.stub(verified=True))
with pytest.raises(HTTPBadRequest) as excinfo:
legacy.file_upload(pyramid_request)
resp = excinfo.value
assert resp.status_code == 400
assert resp.status == "400 Unknown protocol version."
@pytest.mark.parametrize(
("post_data", "message"),
[
# metadata_version errors.
(
{},
"'' is an invalid value for Metadata-Version. "
"Error: This field is required. "
"See "
"https://packaging.python.org/specifications/core-metadata"
" for more information.",
),
(
{"metadata_version": "-1"},
"'-1' is an invalid value for Metadata-Version. "
"Error: Use a known metadata version. "
"See "
"https://packaging.python.org/specifications/core-metadata"
" for more information.",
),
# name errors.
(
{"metadata_version": "1.2"},
"'' is an invalid value for Name. "
"Error: This field is required. "
"See "
"https://packaging.python.org/specifications/core-metadata"
" for more information.",
),
(
{"metadata_version": "1.2", "name": "foo-"},
"'foo-' is an invalid value for Name. "
"Error: Start and end with a letter or numeral containing "
"only ASCII numeric and '.', '_' and '-'. "
"See "
"https://packaging.python.org/specifications/core-metadata"
" for more information.",
),
# version errors.
(
{"metadata_version": "1.2", "name": "example"},
"'' is an invalid value for Version. "
"Error: This field is required. "
"See "
"https://packaging.python.org/specifications/core-metadata"
" for more information.",
),
(
{"metadata_version": "1.2", "name": "example", "version": "dog"},
"'dog' is an invalid value for Version. "
"Error: Start and end with a letter or numeral "
"containing only ASCII numeric and '.', '_' and '-'. "
"See "
"https://packaging.python.org/specifications/core-metadata"
" for more information.",
),
# filetype/pyversion errors.
(
{
"metadata_version": "1.2",
"name": "example",
"version": "1.0",
"md5_digest": "bad",
},
"Invalid value for filetype. Error: This field is required.",
),
(
{
"metadata_version": "1.2",
"name": "example",
"version": "1.0",
"filetype": "bdist_wat",
},
"Error: Python version is required for binary distribution uploads.",
),
(
{
"metadata_version": "1.2",
"name": "example",
"version": "1.0",
"filetype": "bdist_wat",
"pyversion": "1.0",
"md5_digest": "bad",
},
"Invalid value for filetype. Error: Use a known file type.",
),
(
{
"metadata_version": "1.2",
"name": "example",
"version": "1.0",
"filetype": "sdist",
"pyversion": "1.0",
},
"Error: Use 'source' as Python version for an sdist.",
),
# digest errors.
(
{
"metadata_version": "1.2",
"name": "example",
"version": "1.0",
"filetype": "sdist",
},
"Error: Include at least one message digest.",
),
(
{
"metadata_version": "1.2",
"name": "example",
"version": "1.0",
"filetype": "sdist",
"sha256_digest": "an invalid sha256 digest",
},
"Invalid value for sha256_digest. "
"Error: Use a valid, hex-encoded, SHA256 message digest.",
),
# summary errors
(
{
"metadata_version": "1.2",
"name": "example",
"version": "1.0",
"filetype": "sdist",
"md5_digest": "a fake md5 digest",
"summary": "A" * 513,
},
"'" + "A" * 513 + "' is an invalid value for Summary. "
"Error: Field cannot be longer than 512 characters. "
"See "
"https://packaging.python.org/specifications/core-metadata"
" for more information.",
),
(
{
"metadata_version": "1.2",
"name": "example",
"version": "1.0",
"filetype": "sdist",
"md5_digest": "a fake md5 digest",
"summary": "A\nB",
},
"{!r} is an invalid value for Summary. ".format("A\nB")
+ "Error: Use a single line only. "
"See "
"https://packaging.python.org/specifications/core-metadata"
" for more information.",
),
# classifiers are a FieldStorage
(
{
"metadata_version": "1.2",
"name": "example",
"version": "1.0",
"filetype": "sdist",
"classifiers": FieldStorage(),
},
"classifiers: Should not be a tuple.",
),
# keywords are a FieldStorage
(
{
"metadata_version": "1.2",
"name": "example",
"version": "1.0",
"filetype": "sdist",
"keywords": FieldStorage(),
},
"keywords: Should not be a tuple.",
),
],
)
def test_fails_invalid_post_data(
self, pyramid_config, db_request, post_data, message
):
pyramid_config.testing_securitypolicy(userid=1)
user = UserFactory.create()
EmailFactory.create(user=user)
db_request.user = user
db_request.POST = MultiDict(post_data)
with pytest.raises(HTTPBadRequest) as excinfo: