Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Launch arguments of applications #1094

Closed
iLLiCiTiT opened this issue Mar 5, 2021 · 1 comment
Closed

Launch arguments of applications #1094

iLLiCiTiT opened this issue Mar 5, 2021 · 1 comment
Labels
type: enhancement Enhancements to existing functionality

Comments

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Mar 5, 2021

Description

Now we store launch arguments of each application as list [<executable path>, <launch arguments>] which means that for each executable arguments must be filled and user would have to fill them too in local settings. Also want to mention that multiple arguments are stored as one string which may cause issues with bad parsing during launch. Result of current settings is dictionary of list of lists.

{
    "windows": [
        ["my/executable_1.exe", "--quite"],
        ["my/executabke_2.exe", "--quite"]
    ],
    "linux": [],
    "darwin": []
}

Suggested solution

We should store executables and launch arguments separatelly and launch arguments would be same for all executables (per platform). Change structure to:

{
    "windows": {
        "executables": ["my/executable_1.exe", "my/executabke_2.exe"],
        "args": ["--quite"]
    }
}

GUI look

Not sure how to visualize these settings as it may be confusing to set it.

Current look

image

Suggested look

(please ignore only + buttons)
image

Suggested look 2

image

@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Mar 5, 2021
@mkolar
Copy link
Member

mkolar commented May 17, 2021

this has been solved in 3.0

@mkolar mkolar closed this as completed May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants