This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Handle duplication of Task name #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Task name is explicitly set in template, it duplicated it. Task name doesnt need to be in template, but by standard it should be in subset name. This whole replace situation is because of avalon's Creator which modify subset name even if it shouldn't. If Creator app is reworked (could have wide impact!), this should be cleaned up.
mkolar
approved these changes
Mar 31, 2021
kalisp
deleted the
2.x/fix/harmony_task_duplication_in_subset_name_render
branch
mkolar
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.x version of #1225
Issue:
When rendered on farm files with duplicated task name were produced after change of template to explicitly contain Task name (
renderAnimationAnimationDefault)If Task name is explicitly set in template, it duplicated
it here. Task name might need be in template, but by default it should be in subset name.
This whole replace situation is because of avalon's Creator which modify subset name even if it shouldn't.
If Creator app is reworked (could have wide impact!), this should be cleaned up.