This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Fix Avalon plugins attribute overrides #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| print(">>> We have preset for {}".format(plugin_name)) | ||
| for option, value in plugin_settings.items(): | ||
| if option == "enabled" and value is False: | ||
| setattr(plugin, "active", False) |
There was a problem hiding this comment.
Do not call setattr with a constant attribute value, it is not any safer than normal property access.
mkolar
approved these changes
Apr 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Function modifying attributes of avalon plugins is using host integration module to define what is host name which is an issue because we've moved all host integrations into
apifolder so all plugins are looking forapihost in settings.Changes
openpype.libAVALON_APPwhich should always hold host name