Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Feature/sync server priority #1444

Merged
merged 16 commits into from
May 4, 2021
Merged

Feature/sync server priority #1444

merged 16 commits into from
May 4, 2021

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Apr 30, 2021

Implemented priority in Summary View, Detail view, sorting when quering for synchronization.

Single edit on double click or context menu.
Multi edit on context menu only.

@kalisp kalisp added type: enhancement Enhancements to existing functionality module: Sitesync labels Apr 30, 2021
@kalisp kalisp self-assigned this Apr 30, 2021
@kalisp kalisp marked this pull request as ready for review May 3, 2021 13:06
@kalisp
Copy link
Member Author

kalisp commented May 3, 2021

Implemented comments:

Editable action (Reset active or remote site, Set priority) only available if active or remote site is set to local
Priority could be set only on local site
Pausing in Queue GUI pauses only synchronization, not GUI (bug)

@kalisp kalisp requested a review from mkolar May 3, 2021 17:12
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limiting priority to only local site works, albeit only when it is set as active. If local site is set to remote, it's not possible to change the priority, or rather it appears in GUI as if it was possible to change the priority, but the change doesn't take effect.

When no local site is present in Active or Remote, I can also see the edit icon when hovering, but this time can't get to the edit mode at all. We should remove the icon displaying on hover, so we don't confuse the user.

After clicking on priority in representation detail, the edit mode stays active. I reckon it should go back to the original value if the user did it accidentally, and didn't fill anything in there.

image

@kalisp
Copy link
Member Author

kalisp commented May 4, 2021

Fixed mentioned issues.
Reworked when querying is happening.

@kalisp kalisp requested a review from mkolar May 4, 2021 12:34
@mkolar
Copy link
Member

mkolar commented May 4, 2021

Looking good

@mkolar mkolar merged commit e3689f2 into develop May 4, 2021
@mkolar mkolar deleted the feature/sync_server_priority branch May 4, 2021 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Sitesync type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants