Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: re-use instance nodes output path #1577

Merged

Conversation

create-issue-branch[bot]
Copy link

@create-issue-branch create-issue-branch bot commented May 24, 2021

closes #1002

testing notes:

look to original issue for details

@jakubjezek001 jakubjezek001 self-assigned this Jul 22, 2021
@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label Jul 22, 2021
@jakubjezek001 jakubjezek001 force-pushed the bugfix/1002-nuke-re-use-instance-nodes-output-path branch from 66de6dc to 303f2d0 Compare July 22, 2021 09:32
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in 
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
    self.visit(item)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 373, in generic_visit
    self.visit(value)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

@jakubjezek001 jakubjezek001 requested review from iLLiCiTiT and 64qam and removed request for iLLiCiTiT July 23, 2021 13:26
@jakubjezek001 jakubjezek001 marked this pull request as ready for review July 23, 2021 15:35
@64qam
Copy link
Member

64qam commented Jul 23, 2021

Launching Nuke with this PR disallow to use Workfile menu with following error

  File "C:\Users\qam\pypeclub\pype3\pype\openpype\tools\workfiles\app.py", line 1150, in show
    window = Window(parent=parent)
  File "C:\Users\qam\pypeclub\pype3\pype\openpype\tools\workfiles\app.py", line 928, in __init__
    assets_widget.set_current_asset_btn_visibility(True)
AttributeError: 'AssetWidget' object has no attribute 'set_current_asset_btn_visibility'```

@jakubjezek001
Copy link
Member

Launching Nuke with this PR disallow to use Workfile menu with following error

  File "C:\Users\qam\pypeclub\pype3\pype\openpype\tools\workfiles\app.py", line 1150, in show
    window = Window(parent=parent)
  File "C:\Users\qam\pypeclub\pype3\pype\openpype\tools\workfiles\app.py", line 928, in __init__
    assets_widget.set_current_asset_btn_visibility(True)
AttributeError: 'AssetWidget' object has no attribute 'set_current_asset_btn_visibility'```

this seems to be unreleated to this PR

@jakubjezek001 jakubjezek001 merged commit 63a7604 into develop Jul 27, 2021
@jakubjezek001 jakubjezek001 deleted the bugfix/1002-nuke-re-use-instance-nodes-output-path branch July 27, 2021 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuke: re-use instance nodes output path
2 participants