Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

OpenPype specific version issues #1584

Merged
merged 7 commits into from
May 27, 2021

Conversation

create-issue-branch[bot]
Copy link

@create-issue-branch create-issue-branch bot commented May 25, 2021

This is fixing usage of --use-version. When this arguments is used, it will check existing (detected) versions and exit if specified one is not found (previously it used latest one and continued). It will then set it as OPENPYPE_VERSION and use it for all subsequent calls of openpype process.

closes #1583

@antirotor antirotor marked this pull request as ready for review May 25, 2021 15:05
@antirotor antirotor self-assigned this May 25, 2021
@antirotor antirotor added 2x-dev type: bug Something isn't working and removed 2x-dev labels May 25, 2021
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't quite work yet. It correctly reports that the version is missing I have no local versions available and it' sonly comparing to the update repo, however if I have a few versions already in appdata on windows. This will still pick up the latest available, even though it doesn't match what I requested

@antirotor
Copy link
Member

Strange, it worked for me, but nevertheless I've added few enhancements:

  • if version is not found, it will print list of available versions with their respective path
  • removed duplicities in version list
  • when multiple versions match specified one directory is preferred over zip

versions_01

@antirotor
Copy link
Member

last change will sort printed version list if specified one is not found

@mkolar mkolar merged commit d2b2a07 into develop May 27, 2021
@mkolar mkolar deleted the bugfix/1583-openpype-specific-version-issues branch May 27, 2021 09:27
@mkolar mkolar added this to the 3.0.0 milestone May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenPype specific version issues
2 participants