Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya capture 'isolate_view' fix + minor corrections #1614

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Maya capture 'isolate_view' fix + minor corrections #1614

merged 3 commits into from
Jun 1, 2021

Conversation

2-REC
Copy link
Contributor

@2-REC 2-REC commented May 31, 2021

Maya capture 'isolate_view' preset was ignored.
(related to closed issues #367 and #425)

@iLLiCiTiT
Copy link
Member

Updated Qt.py

Qt.py is module in openpype venv so all you need is to use from Qt import ... . Please remove Qt.py from vendor it's on 3 places right now.

@2-REC
Copy link
Contributor Author

2-REC commented Jun 1, 2021

@iLLiCiTiT
I see the problem with a different Qt.py, but it is part of the 'capture_gui' lib/module.
We would need to modify the 'capture_gui' code everywhere it uses Qt.py.

Shouldn't this "vendor module" be independent of Pype, and include its own dependencies?
It is definitely not ideal to have several Qt.py in the project, but does it have an impact on the rest of the project/code?
(The module/file location doesn't seem to be in sys.path, so it should'nt be conflicting)

Do you suggest to adapt the 'capture_gui' code to NOT use its 'vendor' Qt.py, and to rely on Pype's version?

@mkolar
Copy link
Member

mkolar commented Jun 1, 2021

Actually we're not using capture_gui anywhere in the code at all anymore. so we should really remove it completely :D

never noticed, that it stayed behind as legacy

@2-REC
Copy link
Contributor Author

2-REC commented Jun 1, 2021

@mkolar
I saw that in Pype3 the use of 'capture_gui' had been completely removed.
However in pype2 there is still a possible case where it is used: when calling 'load_capture_preset' with empty presets (None or {}), the function 'capture_gui.lib.load_json(path)' is called (resulting also in an error, as 'path' is also None).
It is probably from an older feature that has been removed.

So as you say, it should probably be removed now (even in pype2).
I can removed it and update my branch if you want.

@mkolar mkolar added the type: bug Something isn't working label Jun 1, 2021
@mkolar mkolar added this to the 2.18.1 milestone Jun 1, 2021
@mkolar mkolar changed the base branch from 2.x/main to develop June 1, 2021 15:22
@mkolar mkolar self-requested a review June 1, 2021 15:23
@mkolar mkolar changed the base branch from develop to 2.x/develop June 1, 2021 15:24
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I'm happy with removing capture_gui. the rest is ok. thank you

@mkolar mkolar merged commit 9f0d8b4 into ynput:2.x/develop Jun 1, 2021
@2-REC 2-REC deleted the bc/2.x/fix/capture branch October 10, 2022 04:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants