This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Application launch stdout/stderr in GUI build #1684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Since in built openpype_gui executable is
sys.stdout
andsys.stderr
set toNone
application launched usingsubprocess.Popen
may get blocking handler for output which can cause crash in specific situations. It's small probability and in most of cases it will crash silently but there are cases when this cause unexpected crash of whole application (happened once to me). Most of applications do not rely on stdout set on launch, like maya, But some of them do, like nuke or non python hosts using openpype itself.How to replicate
Changes
sys.stdout
isNone
CREATE_NEW_CONSOLE
flagHow to test
openpype_gui
executable and from codeDepends on ynput/avalon-core#354