Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Local settings UI crash on missing defaults #1737

Merged
merged 5 commits into from
Jun 22, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 22, 2021

Issue

Local settings UI crashes OpenPype tray if there are missing default values for studio settings. This issue will never happen to user(99.99%).

Changes

  • local settings ui won't load any settings until is called reset
  • local settings ui catch errors happened on reset and show them in dialog
    • hide widgets and disable save button
    • reset button is kept there to be able reset local settings when defaults are set
  • local settings action in tray won't trigger reset on first show as that is handled by local settings ui itself

How to test

Easiest is to rename ~/openpype/settings/defaults/system_settings/tools.json to different name. That should cause missing defaults error but tray should be possible to start.

Closes: #1712

@iLLiCiTiT iLLiCiTiT self-assigned this Jun 22, 2021
@iLLiCiTiT iLLiCiTiT added backend type: bug Something isn't working labels Jun 22, 2021
@iLLiCiTiT iLLiCiTiT requested a review from 64qam June 22, 2021 09:48
@iLLiCiTiT iLLiCiTiT merged commit c168791 into develop Jun 22, 2021
@mkolar mkolar deleted the bugfix/local_settings_crash branch August 10, 2021 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local settings crash
2 participants