Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings Hosts enum #1739

Merged
merged 7 commits into from
Jun 23, 2021
Merged

Settings Hosts enum #1739

merged 7 commits into from
Jun 23, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 22, 2021

Description

We use host names in filtering a lot but we don't have enumeration of available hosts in settings.

Changes

  • added hosts-enum entity type which is enumerator with all possible host names
  • has single selection and multiselection option
  • it is possible to have empty value with custom label which is stored as empty string ""
    • to have this set use_empty_value to true/false
  • entity can have defined custom_labels as dictionary where key is host name and valid is label
  • replaced list of strings in hosts usage with new enum item

image

@iLLiCiTiT iLLiCiTiT added backend type: enhancement Enhancements to existing functionality labels Jun 22, 2021
@iLLiCiTiT iLLiCiTiT self-assigned this Jun 22, 2021
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfect

@iLLiCiTiT iLLiCiTiT merged commit 958826d into develop Jun 23, 2021
@mkolar mkolar deleted the feature/hosts_enum branch August 10, 2021 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants