Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Fix - single file files are str only, cast it to list to count properly #1772

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jun 28, 2021

Validate Frames didn't count single file properly. Old implementation expected [], string is provided for single frame.

How to test it:

  • try to publish single image file
  • see error mesage of Validate Frames

@kalisp kalisp added the type: bug Something isn't working label Jun 28, 2021
@kalisp kalisp requested a review from 64qam June 28, 2021 07:59
@kalisp kalisp self-assigned this Jun 28, 2021
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Jun 28, 2021

I think single file in list of 'files' will crash during integration... As it's expected it must be a sequence but can't find out what thre frame ranges are. So it should not continue in validation or raise exception that can't publish single file...

EDITED: Unrelated comment

@kalisp kalisp merged commit 46147cb into develop Jun 30, 2021
@kalisp kalisp deleted the bugfix/sp_validate_frame_single_file branch June 30, 2021 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants