Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Deadline custom settings #1797

Merged
merged 5 commits into from
Jul 12, 2021
Merged

Conversation

antirotor
Copy link
Member

This PR adds ability to customize Deadlines Job_Info and Plugin_Info from presets.

It will update existing data prior to submission, useful for adding / overriding

◀️ Pype 2 backport: #1655

@iLLiCiTiT
Copy link
Member

Question not related to this PR but do we know why Group name is set to string "none" and not empty string by default?

@antirotor
Copy link
Member Author

Question not related to this PR but do we know why Group name is set to string "none" and not empty string by default?

that is how Deadline handles it as default value :) see:
https://docs.thinkboxsoftware.com/products/deadline/10.0/1_User%20Manual/manual/manual-submission.html#general

@iLLiCiTiT
Copy link
Member

that is how Deadline handles it as default value :) see:

I see but in the code is:

if self.group != "none":
    self.payload_skeleton["JobInfo"]["Group"] = self.group

So "Group" is not set only if group is "none". I would just change the condition to if self.group and self.group != "none": to make it valid when it's empty string.

Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@antirotor antirotor merged commit 04e045d into develop Jul 12, 2021
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Jul 14, 2021
@mkolar mkolar deleted the feature/deadline_custom_settings branch August 10, 2021 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants