Maya: fix yeti settings path in extractor

[antirotor]

Invalid variable pointing to file was set in representation in Yeti rig extractor in Maya.

[iLLiCiTiT]

Side question: it seems like settings_path file may not exist if instance.data does not contain "rigsettings" (lines 135-140). Is it ok?

[iLLiCiTiT]

Approved

[antirotor]

Side question: it seems like settings_path file may not exist if instance.data does not contain "rigsettings" (lines 135-140). Is it ok?

Actually I am not sure about that code. I think it will always has rigsettnings - collector will add it here:

https://github.com/pypeclub/OpenPype/blob/a050f92e443f7b5db051a19db8d715e3baf80a1e/openpype/hosts/maya/plugins/publish/collect_yeti_rig.py#L42

but then, the code shouldn't return None if this is not found and so it should fail on assertion.

[iLLiCiTiT]

Actually I am not sure about that code. I think it will always has rigsettnings - collector will add it here:

Well yes. But in the extractor is this:

# Get settings path (the file does not exists yet as far as I can tell from the code)
settings_path = os.path.join(dirname, "yeti.rigsettings")

# Get rig settings from instance
settings = instance.data.get("rigsettings", None)

# Check `"rigsettings" value
# - only if "rigsettings" key is available and value is not empty dictionary is `settings_path` file created
if settings:
    settings["imageSearchPath"] = image_search_path
    with open(settings_path, "w") as fp:
        json.dump(settings, fp, ensure_ascii=False)

# Continue expecting the file `settings_path` exists and going to publish the file as representation :)