Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Prepare for pyside2 #1869

Merged
merged 7 commits into from
Jul 28, 2021
Merged

Prepare for pyside2 #1869

merged 7 commits into from
Jul 28, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jul 27, 2021 •
edited
Loading

Description

Changes required to use PySide2 and keep same (or similar) results as with PyQt5.

Changes

  • stylesheet changes or definitions
  • use direct parenting to propagate style as expected
  • Qt signals have different receivers access

How to test

  • everything should look and behave the same way

@iLLiCiTiT iLLiCiTiT added backend type: enhancement Enhancements to existing functionality labels Jul 27, 2021
@iLLiCiTiT iLLiCiTiT self-assigned this Jul 27, 2021
@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review July 28, 2021 08:53
jakubjezek001
jakubjezek001 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well

@iLLiCiTiT iLLiCiTiT merged commit e154178 into develop Jul 28, 2021
@mkolar mkolar deleted the feature/prepare_for_pyside2 branch August 10, 2021 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@64qam 64qam 64qam approved these changes

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @64qam @jakubjezek001