This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: Scene patching 🩹on submission to Deadline #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antirotor
added
type: enhancement
mkolar
approved these changes
Aug 11, 2021
mkolar
added
type: feature
|
@antirotor Just to confirm - should this ONLY happen when I'm working on refactoring the maya submitter so was wondering how to deal with this patch code best. |
|
Yeah this is patching only published maya ascii files and it'll serves as pretty ugly way to deal with maya inconsistent way of saving files that can lead to crashes on farm. I don't think this is needed anywhere else and even in maya it is really total edge case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
This PR is adding possibility to configure and apply Maya Ascii scene patches directly before submission to Deadline.
This is useful to fix some specific renderer glitches and advanced hacking of Maya Scene files.
Patch nameis label for patch for easier orientation.Patch regexis regex used to find line in file, afterPatch linestring is inserted. Note that you need to add line ending.Patching is done on published scene in submission script.