Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings UI: Breadcrumbs in settings #1932

Merged
merged 41 commits into from
Aug 13, 2021
Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 12, 2021

Description

Orientation in settings UI can be a mess when we're communicating with anyone who's interested in them. Adding breadcrumbs adds easier access to specific items and can open doors for docstring directly in settings UI as it defines "context" of settings.

Changes

  • added breadcrumbs widget to settings UI
  • setting entities has collect_static_entities_by_path which collect all path and entities that are not dynamic
  • list entities has getters and setter implemented
  • reduced number of widgets with replacing Spacing widgets with stretch

Notes

  • it's first version
  • hints of paths works only for static entities (not dynamically created e.g. in list or modifiable dictionary)
  • path is created from key not from labels

Screenshot

image

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 12, 2021
@iLLiCiTiT iLLiCiTiT added backend type: feature Larger, user affecting changes and completely new things labels Aug 12, 2021
@iLLiCiTiT iLLiCiTiT requested review from 64qam and mkolar August 12, 2021 16:22
@iLLiCiTiT iLLiCiTiT removed the backend label Aug 12, 2021
@64qam
Copy link
Member

64qam commented Aug 13, 2021

When I want to insert a known path, the settings jump to the right place and expand the settings correctly for the very first time. The second attempt only expands the required settings but does not move and shows the right items.

Tested for:
project_anatomy/templates/work/folder
project_settings/global/publish/ValidateVersion/enabled
breadcrumbs

@iLLiCiTiT
Copy link
Member Author

When I want to insert a known path, the settings jump to the right place and expand the settings correctly for the very first time. The second attempt only expands the required settings but does not move and shows the right items.

It was issue with checkbox item. Should be fixed now.

@iLLiCiTiT iLLiCiTiT merged commit 2535b08 into develop Aug 13, 2021
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Aug 23, 2021
@mkolar mkolar removed the type: enhancement Enhancements to existing functionality label Sep 17, 2021
@mkolar mkolar deleted the feature/breadcrumbs_in_settings branch September 17, 2021 22:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Larger, user affecting changes and completely new things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants