Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Resolve path when adding to zip #1960

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Resolve path when adding to zip #1960

merged 1 commit into from
Aug 25, 2021

Conversation

2-REC
Copy link
Contributor

@2-REC 2-REC commented Aug 25, 2021

"create_zip" script

When adding files to the zip, the file path is not "resolved", resulting in errors in some cases (eg: when using UNC paths).

For example in Windows if OpenPype is installed on a mapped network drive:

  • Let's consider the directory "\\192.168.1.1\dev" mapped to drive "W" (containing the OpenPype cloned repository).
  • In a PowerShell session, if the current directory is "W:\OpenPype", and the script ".\tools\create_zip.ps1" is executed, the following error occurs:
ValueError: 'W:\\OpenPype\\igniter\\...\\openpype\\action.py' does not start with '\\\\192.168.1.1\\dev\\OpenPype'

and the zip creation is cancelled.
If executing the script in "\\192.168.1.1\dev\OpenPype", the error doesn't occur.

By resolving the path, we avoid the issue.

@mkolar mkolar added the type: bug Something isn't working label Aug 25, 2021
@mkolar mkolar merged commit a2bf654 into ynput:develop Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants