Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Launcher: Fix crashes on action click #1964

Merged
merged 8 commits into from
Aug 27, 2021
Merged

Launcher: Fix crashes on action click #1964

merged 8 commits into from
Aug 27, 2021

Conversation

iLLiCiTiT
Copy link
Member

Issue

There are random crashes on action click in Launcher tool.

Changes

  • animations of clicked actions are stopped before refreshing actions model

Note

  • this is not definite solution of this problem as it requires more testing

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 26, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Aug 26, 2021
@mkolar mkolar self-requested a review August 27, 2021 09:36
mkolar
mkolar approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to replicate this before and I have no issues with this PR either. Let's merge it and see how it behaves in the long run

@iLLiCiTiT iLLiCiTiT merged commit 2e0675d into develop Aug 27, 2021
@mkolar mkolar deleted the bugfix/launcher_crashes branch September 17, 2021 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar