Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Moving project folder structure creation out of ftrack module #1989 #1996

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

icyvapor
Copy link
Contributor

@icyvapor icyvapor commented Sep 9, 2021

  • factor out generic logic out of the ftrack action, into OpenPype lib modules.

Note:

Since I don't have easy access to ftrack, hopefully someone can help with a bit integration testing?

@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Sep 9, 2021
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes requested but good job.

openpype/settings/lib.py Outdated Show resolved Hide resolved
openpype/lib/path_tools.py Outdated Show resolved Hide resolved
openpype/lib/path_tools.py Outdated Show resolved Hide resolved
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mkolar mkolar merged commit 9ad4c23 into ynput:develop Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants