-
Notifications
You must be signed in to change notification settings - Fork 129
Loader & Library loader: Use tools from OpenPype #2038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 363, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 371, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 373, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 363, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 371, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 373, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 363, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 371, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 373, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 363, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 371, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 373, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 363, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 371, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 373, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
Description
We need to do OpenPype specific changes in loader (and library loader). This is first step just moving and modify imports to work exactly the same way without any huge modifications.
Changes
utils
where are general widgets/delegates/models for toolsNote
I want to make this switch quick so I've changed code in this PR only as needed to work as before.