Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint: Creator use context from workfile #2087

Merged
merged 1 commit into from
Oct 5, 2021
Merged

TVPaint: Creator use context from workfile #2087

merged 1 commit into from
Oct 5, 2021

Conversation

iLLiCiTiT
Copy link
Member

Issue

Creators are using context from avalon.api.Session which may not be the same as context of current workfile.

Changes

TVPaint creators set asset and task keys using dynamic data loaded from currently opened workfile.

@iLLiCiTiT iLLiCiTiT self-assigned this Sep 29, 2021
@iLLiCiTiT iLLiCiTiT added type: bug Something isn't working host: TV Paint labels Sep 29, 2021
mkolar
mkolar approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the code front, but @64qam should test out on client site.

64qam
64qam approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@iLLiCiTiT iLLiCiTiT merged commit cad9db6 into develop Oct 5, 2021
@iLLiCiTiT iLLiCiTiT deleted the bugfix/tvpaint_creator_use_context_values branch December 13, 2021 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

@64qam 64qam 64qam approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
host: TV Paint type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @mkolar @64qam