This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Added choosing different dirmap mapping if workfile synched locally #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisp
added
type: enhancement
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| mapping["destination-path"] = [value] | ||
| mapping["source-path"] = [sync_settings["sites"]\ | ||
| [remote_site]\ | ||
| ["root"]\ |
There was a problem hiding this comment.
the backslash is redundant between brackets
whitespace before '['
| try: | ||
| mapping["destination-path"] = [value] | ||
| mapping["source-path"] = [sync_settings["sites"]\ | ||
| [remote_site]\ |
There was a problem hiding this comment.
the backslash is redundant between brackets
whitespace before '['
| if os.path.isdir(value): | ||
| try: | ||
| mapping["destination-path"] = [value] | ||
| mapping["source-path"] = [sync_settings["sites"]\ |
There was a problem hiding this comment.
the backslash is redundant between brackets
whitespace before '['
mkolar
approved these changes
Sep 29, 2021
kalisp
deleted the
PYPE-1941_Run-different-dirmap-for-locally-synched-workfiles
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this checks if Site Sync is enabled (globally and for project) and if User has set
active_sitetolocal(eg. User is synching files locally). If so, it puts intodirmaproot(s) fromremote_siteas a source andlocalsite as a destination.It completely ignores configuration in Settings, if anyone could produce use case when this would be needed, please go ahead and share.
(I am not super happy about mixing Site Sync logic with host implementation, but couldn't figure out better option.)