Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Burnins: DNxHD profiles handling #2142

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

iLLiCiTiT
Copy link
Member

Issue

When DNxHD input is passed to burnins script it won't use input's profile so may crash because default profile is used in that moment which has different requirements for bitrate and resolution so conversion fails.

Changes

  • use dnxhd profile from input metadata

How to test

  • set ffmpeg arguments in extract review to create dnxhd output with profile different thant dnxhd
    • example:
     "output": [
        "-codec:v dnxhd",
        "-profile:v dnxhr_lb",  # This is important line
        "-pix_fmt yuv422p",
        "-b:v 36M"
    ]
    
  • add burnins tag on the output
  • check if burnins crash

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 18, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Oct 18, 2021
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@iLLiCiTiT iLLiCiTiT merged commit 3c1b04a into develop Oct 18, 2021
@iLLiCiTiT iLLiCiTiT deleted the feature/burnin_dnxhd_profiles_handling branch December 13, 2021 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants