Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings: Site sync project settings improvement #2193

Merged

Conversation

iLLiCiTiT
Copy link
Member

Description

Reduce settings of sites for sync server in project settings. Now it shows settings for all providers for each site name and site names must be manually added.

Changes

  • added new settings entity sync-server-sites
  • entity works as dictionary children based on sync server system settings
  • all site names are always available in project settings
    • each site have enabled boolean to know if should be enabled for the project
  • other schemas for value are get from providers using get_project_settings_schema

TODO

Use this entity and replace current site item in settings. That require to modify how sync server module uses settings and probably will have to keep backwards compatibility. So it should be done in different PR.

How to test

Change sites in project settings schemas to this:

{
    "type": "sync-server-sites",
    "collapsible": true,
    "key": "sites",
    "label": "Sites",
    "collapsible_key": false
}

File ~/openpype/settings/entities/schemas/projects_schema/schema_project_syncserver.json

@mkolar
Copy link
Member

mkolar commented Nov 1, 2021

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 1, 2021
@iLLiCiTiT iLLiCiTiT requested a review from kalisp November 1, 2021 17:03
@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review November 1, 2021 17:03
@iLLiCiTiT iLLiCiTiT merged commit 4456cae into develop Nov 5, 2021
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Nov 15, 2021
@mkolar mkolar deleted the feature/OP-1939_Site-sync-project-settings-improvement branch January 6, 2022 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Sitesync type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants