Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Reduce vendor imports #2305

Merged
merged 2 commits into from
Nov 29, 2021
Merged

General: Reduce vendor imports #2305

merged 2 commits into from
Nov 29, 2021

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • removed imports from avalon vendor and expect that modules are available in sys path
    • modules imported from avalon vendor were Qt, clique, six and requests
    • all of them must be in sys path else almost everything wouldn't work

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 25, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Nov 25, 2021
jakubjezek001
jakubjezek001 approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on opening nuke and tried to publish.. all worked..

@iLLiCiTiT iLLiCiTiT merged commit abb1098 into develop Nov 29, 2021
@iLLiCiTiT iLLiCiTiT deleted the feature/reduce_vendor_imports branch December 13, 2021 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @jakubjezek001