This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: MongoDB ability to specify replica set groups #2401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Replica sets may require to pass mutliple urls into mongo url (e.g.:
mongodb://localhost:27017,localhost:27018/?replicaSet=foo
).Description
That is not now possible because we're parsing mongo url into components for
MongoHandler
. As nothing from the decomposed url parts is at the end used we don't really need "real" connection data. This should give ability to enter any valid mongo url and not crash on logging creation.Changes
decompose_url
andcompose_url
from openpypelib
andapi
compose_url
completellydecompose_url
to_decompose_url
and use it only inget_default_components
How to test
Resolves #2226