Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Fix published frame content for sequence starting with 0 #2513

Merged

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jan 11, 2022

Brief description

Previously expression didn't trigger as repre.get("frameStart") returned 0 which translated into False

Description

This resulted in using frame value in source padding which might had been different from final, correct value.

Additional info

In AE it manifested when artist manually updated frame pattern in Render Queue, used more # than is in final pattern from Anatomy (which is ####). AE rendered locally files with 00000 temporarily, integrate_new used correct padding for publishing, but representation.context.frame stayed with wrong value (00000 instead of 0000).
This might have happened in another hosts too.

Testing notes:

  1. add new Render Queue in AE, choose "PNG" as destination format
  2. modify name there to contain more or less # than 4
  3. render locally
  4. check published files, they will be correct
  5. check representation in DB (db.getCollection('petr_test').find({type:"representation", name:"png"}).sort({"_id": -1})) , its context.frame will match source pattern
  6. Try to load this published representation (you can load it in AE directly) - it should fail

Previously expression didn't trigger as repre.get("frameStart") returned 0 which translated into False
@kalisp kalisp added type: bug Something isn't working host: After Effects labels Jan 11, 2022
@kalisp kalisp self-assigned this Jan 11, 2022
@mkolar
Copy link
Member

mkolar commented Jan 11, 2022

@kalisp kalisp merged commit f352144 into develop Jan 12, 2022
@kalisp kalisp deleted the bugfix/OP-2049_after-effects-publishing--frame-padding-fix branch January 12, 2022 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: After Effects type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants