This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Houdini: vdbcache family preserve frame numbers on publish integration + enable validate version for Houdini #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
This PR fixes a bug with VDB publishes from Houdini so that it actually preserves its original frame numbers (otherwise would always get remapped to start at frame 0 by the integrator - even though the loader would still show frameStart and frameEnd as the non-remapped range.)
frameStartdata to be present on therepresentationsto preserve the frame numbers upon integrating - I've addedframeEndtoo just to be consistent.familiesdata otherwise the integrator would error herePublishing frame range 1000-1015
Before:
publish.0000.vdb - publish.0015.vdbAfter:
publish.1000.vdb - publish.1015.vdbThis PR also enabled Validate Version for Houdini since that was disabled - which without it accidentally allowed me to publish into an already published version because I had Match Work File Version enabled in the test project. Which seemed like a required fix for Houdini too - since it's a small PR. :)