Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Loader: Allow to toggle default family filters between "include" or "exclude" filtering #2541

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jan 16, 2022

Brief description

This implements #2516

It adds an extra boolean checkbox in Admin Settings for Family Filters to decide whether the filtering is to "include" what you've selected or to "exclude" what you've selected.

Like the label describes in settings it works like this:

  • Include: show selected families by default. Hides others by default.
  • Exclude: hide selected families by default. Shows others by default.

So on Exclude always all families will be enabled except for those selected in the filter. On Include, it behaves like before, only the families you select in settings are enabled by default in the Loader.

Screenshot

This is how it looks in Settings:
family_filter_include_exclude

Testing notes:

👍 I tested it in Maya 2020 on both include and exclude mode and it worked as intended.

@BigRoy BigRoy changed the title Allow to toggle family filters between "include" or "exclude" filtering Loader; Allow to toggle default family filters between "include" or "exclude" filtering Jan 16, 2022
@BigRoy BigRoy changed the title Loader; Allow to toggle default family filters between "include" or "exclude" filtering Loader: Allow to toggle default family filters between "include" or "exclude" filtering Jan 16, 2022
@iLLiCiTiT
Copy link
Member

I would just reduce the texts. The label should be moved before the checkbox and should have just one line Include/Exclude selected families ..... I think the (OFF) and (ON) is not needed too.

@mkolar
Copy link
Member

mkolar commented Jan 20, 2022

I agree with @iLLiCiTiT that Exclude / Include as a label would be enough. We're designing a way to include in -situ documentation for all possible settings, so this verbose approach will be obsolete hopefully soon.

@antirotor antirotor added the type: enhancement Enhancements to existing functionality label Jan 20, 2022
@BigRoy
Copy link
Collaborator Author

BigRoy commented Jan 23, 2022

Removed the description label and reduced the checkbox label to solely Exclude / Include with commit d5bae9c

It now looks like this:
family_filter_include_exclude_simplified

@mkolar mkolar merged commit 6238d63 into ynput:develop Jan 24, 2022
@BigRoy BigRoy deleted the family_filter_include_exclude branch March 20, 2024 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants