Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings: PathInput strip passed string #2550

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Settings: PathInput strip passed string #2550

merged 1 commit into from
Jan 18, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

PathInput makes sure there are no whitesymbols at the start/end of value.

Changes

  • strip value of PathInput on set and on loading of settings values

Testing notes:

  1. Try to pass any path starting/ending with space

@iLLiCiTiT iLLiCiTiT self-assigned this Jan 17, 2022
@iLLiCiTiT iLLiCiTiT requested review from 64qam, jrsndl and kalisp and removed request for jrsndl January 17, 2022 17:46
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Jan 17, 2022
@iLLiCiTiT iLLiCiTiT mentioned this pull request Jan 17, 2022
Closed
kalisp
kalisp reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be on TextInput too?

On paths it is working

@iLLiCiTiT
Copy link
Member Author

Shouldn't it be on TextInput too?

Not by default but I think it can be added with changing key in schema. Not related to this PR.

@iLLiCiTiT iLLiCiTiT merged commit f28b424 into develop Jan 18, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/strip_path_input_value branch January 19, 2022 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kalisp kalisp kalisp left review comments

@64qam 64qam 64qam approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @kalisp @64qam