This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
hotfix: OIIO tool path - add extension on windows #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
get_oiio_tools_path()didn't take into account extension on windows. So trying to get path formaketx- returned path likeC:\foo\bar\oiio\bin\maketxthat is invalid on Windows because it should beC:\foo\bar\oiio\bin\maketx.exe. This PR is providing simple fix to add.exeon windows if it is missing. Note that it will not work for other executable files on windows, like shell scripts, and so on, but because this is strictly OIIO tool specific I don't see problem with it.Without this fix, extracting looks from maya on windows will fail.