This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: cleanup duplicate rendersetup code #2642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
This resolves #2637 by removing
attributes.py
and pushing some of the "OpenPype" changes directly tolib_rendersetup.py
.This also refactors the single use/import of
attributes.py
to use this one instead.Testing notes
Tested in Maya 2020 + 2022 using this:
Test RenderSetup absolute overrides on a camera.renderable ✅
Also quickly did
CreateRender
in Maya 2020 to see if all Collector still collect fine. And they did! Be aware however that you'll need to add a renderable camera to the DisabledCamera layer for it to collect correctly - otherwise you'll see ano render products generated
error due to the renderlayer having no renderable camera set at all.