Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Launcher: Fix access to 'data' attribute on actions #2659

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Launcher: Fix access to 'data' attribute on actions #2659

merged 1 commit into from
Feb 9, 2022

Conversation

iLLiCiTiT
Copy link
Member

Description

Changing of attribute data breaks other than application actions because they don't have data attribute.

Changes

  • Change of data happens only on ApplicationAction classes

@iLLiCiTiT iLLiCiTiT self-assigned this Feb 4, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Feb 4, 2022
@iLLiCiTiT iLLiCiTiT mentioned this pull request Feb 4, 2022
Closed
@BigRoy
Copy link
Collaborator

BigRoy commented Feb 4, 2022

Code looks good to me. I prefer this code over #2660
Will test next week.

BigRoy
BigRoy approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@iLLiCiTiT iLLiCiTiT merged commit 7f74b10 into develop Feb 9, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/launcher_action_data_existence branch February 9, 2022 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@kalisp kalisp kalisp approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @BigRoy @kalisp