This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Houdini Explicitly collect correct frame name even in case of single frame render when frameStart
is provided
#2676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 0f82a75)
Brief description
There was a bug in Houdini that whenever you do have a frame range set of just a single frame, e.g.
1001-1001
thencollect_frames
would actually eval the filename on the current frame instead of that start frame. Thus if you're writing to a file with$F
the file would be named different than what the ROP node would actually outputAdditional info
Here's an example error that could happen. The integrator here fails to copy the file becuase the ROP node actually rendered another file than was "collected" as expected resulting filename from the ROP node.
Testing notes:
The render rop will render
1001
however the collect_frames and thus integrator thinks1002
should be published.Additional Context
I've also added a warning if it's rendering without a frame range set and thus renders current frame - since that is less reliable in a production environment and thus discouraged?