Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Multiple hosts: unify menu style across hosts #2693

Merged
merged 12 commits into from
Feb 14, 2022
Merged

Multiple hosts: unify menu style across hosts #2693

merged 12 commits into from
Feb 14, 2022
+78 −40

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Feb 10, 2022 •
edited
Loading

Brief description

Some hosts were missing Library loader menu item

Description

This will allow to use Library loader across most of supported DCC

Additional info

Triple dot stile Library... was unified to keep one style only without space between word

Testing notes:

  1. open your host
  2. see there is available Library... under Manage...
  3. It should open Library Loader
  4. Also check the triple dots are not having space between word

Tested hosts

  • Houdini
  • Nuke
  • Hiero
  • Fusion
  • Resolve
  • Flame

@jakubjezek001 jakubjezek001 self-assigned this Feb 10, 2022
@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label Feb 10, 2022
iLLiCiTiT
iLLiCiTiT suggested changes Feb 10, 2022
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Houdini is missing loader

@m-u-r-p-h-y
Copy link
Member

Blender is missing Library...

jakubjezek001 and others added 2 commits February 11, 2022 10:06
@jakubjezek001 @iLLiCiTiT
Update openpype/hosts/houdini/startup/MainMenuCommon.xml
c1166ea 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@jakubjezek001
houdini: add loader back
5f3f1e4 
#2693 (comment)
iLLiCiTiT
iLLiCiTiT approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maya , Nuke and Houdini works.

@BigRoy
Copy link
Collaborator

BigRoy commented Feb 12, 2022

@jakubjezek001 note that I pushed a tweak directly into this branch since it was a minor cosmetic tweak to remove dots after the words in the menu in Fusion too.

Also tested Maya + Houdini. Works! ✅

BigRoy
BigRoy reviewed Feb 12, 2022
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Flame and Unreal still seem to have a space between the words and the triple dots.

Should that get patched in this PR too? The PR title doesn't mention it but the description does say "unify style across hosts".

@jakubjezek001
Merge remote-tracking branch 'origin/bugfix/missing-library-loader-in…
9015dd4 
…-menu' into bugfix/missing-library-loader-in-menu
@jakubjezek001
Copy link
Member Author

@jakubjezek001 note that I pushed a tweak directly into this branch since it was a minor cosmetic tweak to remove dots after the words in the menu in Fusion too.

Also tested Maya + Houdini. Works! ✅

awesome, thanks!

@jakubjezek001
Copy link
Member Author

unify style across hosts

good catch, I will change the topic and fix the rest. Thaks for noticig ;)

@jakubjezek001 jakubjezek001 changed the title Multiple hosts: adding missing Library menu item Multiple hosts: unify menu style across hosts Feb 14, 2022
@mkolar
Copy link
Member

mkolar commented Feb 14, 2022

Task linked: OP-2629 hosts: menu style unification

@jakubjezek001
Copy link
Member Author

the Unreal integration will be soon merged into OpenPype codebase from spreaded repositories and the menu style unification will be part of the move.. #2433

@jakubjezek001 jakubjezek001 mentioned this pull request Feb 14, 2022
Closed
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blender is loading ok

image

@jakubjezek001 jakubjezek001 merged commit d82255e into develop Feb 14, 2022
@jakubjezek001 jakubjezek001 deleted the bugfix/missing-library-loader-in-menu branch February 14, 2022 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@BigRoy BigRoy Awaiting requested review from BigRoy

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees

@jakubjezek001 jakubjezek001

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakubjezek001 @m-u-r-p-h-y @BigRoy @mkolar @iLLiCiTiT