Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Loader: Remove default family states for hosts from code #2706

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Feb 12, 2022

Description

This removes the Avalon data being set for familiesStateToggled and familiesStateDefault from the install() logic for hosts.

Specifically:

  • avalon.api.data["familiesStateToggled"]
  • avalon.api.data["familiesStateDefault"]

This can be removed since the code does nothing within OpenPype due to overriding this behavior with the admin settings with project_settings/global/tools/loader/family_filter_profiles

Question

Even though it currently did nothing within OpenPype - would we like to save default settings with OpenPype that match what this code did originally. The current OpenPype default settings define no filtering whatsoever.

Testing notes:

  1. Run OpenPype without! this PR and confirm the original code indeed does nothing in OpenPype.
  2. Run a host with this PR and make sure the tools, specifically loader and library loader still work.

I tested both in Maya + Houdini. Also tested with custom settings set in Admin Settings for a host and with settings removed in OpenPype for a host. Behavior was the same before and after - nothing being filtered when not set in settings.

@iLLiCiTiT iLLiCiTiT assigned iLLiCiTiT and BigRoy and unassigned iLLiCiTiT Feb 15, 2022
@iLLiCiTiT iLLiCiTiT merged commit 173551e into ynput:develop Feb 15, 2022
@BigRoy BigRoy deleted the remove_host_default_family_states branch March 20, 2024 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants