Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Local Settings: Additional applications don't break UI #2710

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Local Settings: Additional applications don't break UI #2710

merged 2 commits into from
Feb 14, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Additional applications break local settings UI because does not handle properly labels of dynamic entities.

Changes

  • fix how labels are defined in local settings

Testing notes:

  1. Add new additional application to system settings (with variant)
  2. Open local settings which should work and containt the application

@iLLiCiTiT iLLiCiTiT self-assigned this Feb 14, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Feb 14, 2022
@iLLiCiTiT iLLiCiTiT merged commit 666d161 into develop Feb 14, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/additional_apps_break_local_settings branch February 14, 2022 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@64qam 64qam 64qam approved these changes

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @64qam @jakubjezek001