Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings: Missing document with OP versions may break start of OpenPype #2825

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Settings: Missing document with OP versions may break start of OpenPype #2825

merged 2 commits into from
Mar 1, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Settings in some cases expect that a versioned document already exists and does not handle it.

Changes

  • Make sure that function returning versioned doc makes sure that result is dictionary and not None
  • Side change: Replaced _Callback with functools.partial ( related discussion )

Testing notes:

  1. On fresh mongo start OpenPype with specified version that is not build version - start should not crash

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 1, 2022
@iLLiCiTiT iLLiCiTiT requested a review from kalisp March 1, 2022 14:05
@iLLiCiTiT iLLiCiTiT added backend type: bug Something isn't working labels Mar 1, 2022
@iLLiCiTiT iLLiCiTiT changed the title Settings UI: Missing document with OP versions may break start of OpenPype Settings: Missing document with OP versions may break start of OpenPype Mar 1, 2022
@iLLiCiTiT iLLiCiTiT merged commit a360577 into develop Mar 1, 2022
@iLLiCiTiT iLLiCiTiT mentioned this pull request Mar 1, 2022
Merged
@iLLiCiTiT iLLiCiTiT deleted the bugfix/versioned_doc_may_not_exists branch March 1, 2022 15:51
@mkolar mkolar added this to the 3.9.0 milestone Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kalisp kalisp kalisp approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @kalisp @mkolar