Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

AfterEffects: Allow configuration of default variant via Settings #2856

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Mar 9, 2022

Brief description

Variant name for subset name creation was hardcoded. Now it is possible to configure it via Settings.

Description

Implemented as a part of move to New Publisher.
Multiple variants possible.

Additional info

Depends on #2838. Should be tested by merging to #2838 as that branch might contain new updates/fixes for general behavior in NP.

Testing notes:

  1. Configure required value in Settings:project_settings/aftereffects/create/RenderCreator
  2. Open render creator in NP, check value in the middle bottom (just above gray colored final subset name)

@kalisp kalisp requested a review from 64qam March 9, 2022 10:14
@kalisp kalisp self-assigned this Mar 9, 2022
@ynbot
Copy link
Contributor

ynbot commented Mar 9, 2022

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 10, 2022

@kalisp any reason you are not making this PR to #2838 directly?

…68_After-effects-creator-Subset-name-change-to-main-rather-than-default
@kalisp
Copy link
Member Author

kalisp commented Mar 10, 2022

@BigRoy its separate issue in our tracker, just red tape reasons

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 10, 2022

@kalisp would that disallow rebasing this PR on top of that PR instead? :) That way it'd easier to read the changelog (since I believe this currently also show changes as made in that PR, no?)

@mkolar
Copy link
Member

mkolar commented Mar 14, 2022

its separate issue in our tracker, just red tape reasons

Let's pull off that red tape. It is possible to manually link PR to clickup task for these situations, which should make it easier then.

…eator-Subset-name-change-to-main-rather-than-default' into feature/OP-2868_After-effects-creator-Subset-name-change-to-main-rather-than-default
…P-2868_After-effects-creator-Subset-name-change-to-main-rather-than-default
@kalisp kalisp merged commit 628bc87 into develop Apr 22, 2022
@kalisp kalisp deleted the feature/OP-2868_After-effects-creator-Subset-name-change-to-main-rather-than-default branch April 22, 2022 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants