This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Flame: sequence used for reference video #2869
Merged
+181
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-2732 Flame: rendering presets from sequence |
jakubjezek001
added
host: Flame
iLLiCiTiT
reviewed
Mar 11, 2022
| @@ -63,7 +63,7 @@ def execute(self): | |||
| _db_p_data = project_doc["data"] | |||
| width = _db_p_data["resolutionWidth"] | |||
| height = _db_p_data["resolutionHeight"] | |||
| fps = float(_db_p_data["fps"]) | |||
| fps = float(_db_p_data["fps_string"]) | |||
There was a problem hiding this comment.
I think that "fps" should be used here.
There was a problem hiding this comment.
here is what I am having in my project data
with mark in/out it should only publish particular segment
iLLiCiTiT
suggested changes
Mar 16, 2022
openpype/hosts/flame/plugins/publish/extract_subset_resources.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
approved these changes
Mar 16, 2022
jakubjezek001
deleted the
feature/OP-2732_Flame-rendering-presets-from-sequence
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Publishing from sequence will bake retimes and other timeline actions.
Description
Publishing from clips was not good enough because retimes were not rendered into the reference videos. Also other timeline actions are not baked into the image because they are timeline segment related.
Additional info
fpswith string type