This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Refactor: move webserver tool to openpype #2876
Merged
+253
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisp
added
host: After Effects
type: refactor
|
Task linked: OP-2815 Move webserver tool to openpype |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| try: | ||
| sock.bind((host_name, port)) | ||
| result = False | ||
| except: |
There was a problem hiding this comment.
Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
do not use bare 'except'
| """ | ||
| Check if 'url' is already occupied. | ||
|
|
||
| This could mean, that app is already running and we are trying open it |
64qam
approved these changes
Mar 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Part of incorporating of avalon-core repo into openpype.
Description
Webserver moved to
adobe_webserveras both AE and PS should use same logic.Testing notes: