Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Multiverse: Initial Support #2908

Merged
merged 64 commits into from
Mar 29, 2022
Merged

Conversation

zhoub
Copy link
Contributor

@zhoub zhoub commented Mar 18, 2022

Brief description

First PR for Multiverse

Description

Support Multiverse at OpenPype

Additional info

Documentation (add "type: documentation" label)

https://j-cube.jp/solutions/multiverse/docs/dev/

Testing notes:

  1. Install Multiverse as free user and setup it to OpenPype
  2. Create USD, USD Composition, USD Override from Maya and publish them.
  3. Load USD firstly to Maya, and Copy File path to USD Override and add it as USD layer at Maya.

zhoub added 25 commits March 4, 2022 18:16
@zhoub zhoub changed the title Feature/multiverse Multiverse: First PR Mar 18, 2022
@zhoub zhoub mentioned this pull request Mar 18, 2022
@mkolar mkolar added the type: feature Larger, user affecting changes and completely new things label Mar 18, 2022
@mkolar mkolar requested a review from antirotor March 18, 2022 08:07
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid update once again, thanks a lot! I did see some things that still stood out to me - nothing huge.

@zhoub zhoub requested a review from BigRoy March 25, 2022 09:18
@BigRoy
Copy link
Collaborator

BigRoy commented Mar 25, 2022

Solid stuff - unfortunately I don't have the time to actually give this a production test run, but the code looks good to me.

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I could test with free MV6 it does work as expected, excelent work! The only think I miss is documentation and maybe default setup of MV as a tool in the Settings that could easy deployment. We could add by default something like this (but change it so it will be multiplatform):

image

@zhoub
Copy link
Contributor Author

zhoub commented Mar 26, 2022

Thanks a lot for testing.

@zhoub zhoub requested a review from mkolar March 29, 2022 00:39
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave adding it as a tool to the studio and rather show what environments are needed for it in the documentation.

That being said I agree with @antirotor that documentation for this workflow is needed. If you're planning to document this on your end, then I think we can merge this

@antirotor antirotor merged commit 572e640 into ynput:develop Mar 29, 2022
@zhoub zhoub deleted the feature/multiverse branch March 29, 2022 12:41
@pberto
Copy link
Contributor

pberto commented Mar 30, 2022

I think we will add a page in our documentation first, then we can give you a link to it. But maybe we should also write a short documentation on the OP docs. Could you point me to a documentation of a similar tool? (such as the alembic creator and loader?)

@mkolar mkolar changed the title Multiverse: First PR Multiverse: Initial Support Mar 31, 2022
@mkolar
Copy link
Member

mkolar commented Mar 31, 2022

@pberto this is the closest example probably https://openpype.io/docs/artist_hosts_maya#working-with-yeti-in-openpype

@pberto
Copy link
Contributor

pberto commented Apr 13, 2022

I know this PR is closed, but I would like to show the docs I am working on. It would be good to know if the style makes sense before making going far, then I make a doc pr:

j-cube@70fe3f8

@BigRoy
Copy link
Collaborator

BigRoy commented Apr 13, 2022

I know this PR is closed, but I would like to show the docs I am working on. It would be good to know if the style makes sense before making going far, then I make a doc pr:

Do you still need to add the images in the documentation to the Branch?

Other than that I feel the documentation looks very solid and thorough. Some bits might be somewhat "generic OpenPype" information too, regarding how creators work etc. But I don't feel that's in the way currently.

@pberto
Copy link
Contributor

pberto commented Apr 13, 2022

Yes I did not add the images yet. Glad you like it. I will get through it :)

@pberto
Copy link
Contributor

pberto commented May 13, 2022

Next PR is in: #3178

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Larger, user affecting changes and completely new things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants