Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: Add no-audio Tag #2911

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Nuke: Add no-audio Tag #2911

merged 1 commit into from
Mar 25, 2022

Conversation

jrsndl
Copy link
Collaborator

@jrsndl jrsndl commented Mar 18, 2022

Allow skipping audio for reviews.

Brief description

Some reviews can't have audio. This tag allows to flag reviews to be mute.

Description

Ffmpeg can fail adding audio to files that cant' have any, like OpAtom MXFs

Testing notes:

  1. Add no-audio flag in extractReview profile
  2. Publish shot with audio available (from Nuke)
  3. Check that review is mute

Allow skipping audio for reviews.
@jrsndl jrsndl self-assigned this Mar 18, 2022
@jrsndl jrsndl added the type: enhancement Enhancements to existing functionality label Mar 18, 2022
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this will solve the issue. By adding tag to newly created representation which is having audio included, we are telling publish plugins which will follow downstream to ignore audio.

In case you want to exclude audio processing on particular output profile, it has to be added as bool attribute.

@mkolar mkolar changed the title Add no-audio Tag NUke: Add no-audio Tag Mar 18, 2022
@mkolar
Copy link
Member

mkolar commented Mar 18, 2022

I think this does solve the issue. The extractReview code is already counting of the possibility of this tag being present in the output profile, but we're not actually able to use it because it's not present in the schema. This just makes it available.

@BigRoy BigRoy changed the title NUke: Add no-audio Tag Nuke: Add no-audio Tag Mar 18, 2022
@jakubjezek001 jakubjezek001 merged commit 62182df into develop Mar 25, 2022
@mkolar mkolar added this to the next milestone Apr 4, 2022
@mkolar mkolar deleted the feature/add-no-audio-tag branch May 30, 2022 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants