Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Move formatting and workfile functions #2914

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 18, 2022

Brief description

Move functions from avalon that are related to calculation of last workfile path and optional template formatting.

Description

Usage of format_template_with_optional_keys function is replaced with StringTemplate.
Functions last_workfile_with_version renamed to get_last_workfile_with_version and last_workfile renamed to get_last_workfile and both moved to openpype/lib/avalon_context.py.

Testing notes:

  1. Workfiles tool should be able to find last workfile version and use next available (when save as is clicked)
  2. Last workfile should be launched on host start (if the feature is enabled!)
  3. Modified string formatting should work as did

Related to PR ynput/avalon-core#434

@ynbot
Copy link
Contributor

ynbot commented Mar 18, 2022

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 18, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Mar 18, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Mar 18, 2022
@mkolar mkolar removed the type: enhancement Enhancements to existing functionality label Mar 18, 2022
@iLLiCiTiT iLLiCiTiT merged commit 5aaa4c1 into develop Mar 18, 2022
@iLLiCiTiT iLLiCiTiT deleted the enhancement/OP-2947_move-formatting-and-workfile-functions branch March 18, 2022 17:25
@mkolar mkolar added this to the next milestone Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants