This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Don't print log record on OSError #2926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
It seems that crashed log emit in
openpype_gui
(windows) can sometimes raise an OSError on stream write which fallbacks to exception handling that tried do the same usingprint
so crashes again.Changes
Note
It would be good to find out real reason. This was discovered in Ftrack action server subprocess.
Testing notes:
openpype_gui.exe
with enabled Ftrack modulePrepare Project
on any project