Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Don't print log record on OSError #2926

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

It seems that crashed log emit in openpype_gui (windows) can sometimes raise an OSError on stream write which fallbacks to exception handling that tried do the same using print so crashes again.

Changes

  • don't print record if OSError is raised during writing

Note

It would be good to find out real reason. This was discovered in Ftrack action server subprocess.

Testing notes:

  1. Run tray using openpype_gui.exe with enabled Ftrack module
  2. Run Prepare Project on any project
  3. A form with inputs should be shown

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 21, 2022
@iLLiCiTiT iLLiCiTiT requested review from 64qam and kalisp March 21, 2022 18:05
@iLLiCiTiT iLLiCiTiT added type: bug Something isn't working module: Ftrack labels Mar 21, 2022
@iLLiCiTiT iLLiCiTiT merged commit 87a0663 into develop Mar 22, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/dont_print_record_on_oserror branch March 22, 2022 11:08
@mkolar mkolar added this to the next milestone Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Ftrack type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants